Respect exist_ok in mkdir when creating parent directories #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Requesting review: @normanrz |
rahuliyer95
force-pushed
the
issue-82/fix-mkdir
branch
from
33024d9 to
fbb9c72
Compare
Contributor
Author
|
@normanrz if you can please take another pass at it, now that the tests are passing, Thanks! |
Collaborator
|
Thanks for the PR. The code looks good to me. Would you mind adding a test for |
normanrz
approved these changes
Mar 11, 2023
Collaborator
normanrz
left a comment
normanrz
left a comment
There was a problem hiding this comment.
Thank you very much for putting together this PR!
Collaborator
|
I just published it in v0.0.22 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #82