Implement byte padding for Elliptic Curve point encoding as fix for #173#174
Merged
fszlin merged 4 commits intofszlin:masterfrom Dec 13, 2018
webprofusion:master
Merged
Implement byte padding for Elliptic Curve point encoding as fix for #173#174fszlin merged 4 commits intofszlin:masterfrom webprofusion:master
fszlin merged 4 commits intofszlin:masterfrom
webprofusion:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 95.21% 95.22% +<.01%
==========================================
Files 103 103
Lines 2342 2344 +2
Branches 256 256
==========================================
+ Hits 2230 2232 +2
Misses 57 57
Partials 55 55 |
Collaborator
Author
|
Ok, I think this is clean enough to leave as-is, unless @fszlin has any suggestions! |
Collaborator
Author
|
I have added attributes to JsonWebKey and it's derivatives to enforce the serialization order of properties. One user was getting an incorrect Account Key thumbprint during challenges as the key properties were serializing in a different (non-alphabetical) order resulting in a different json string being hashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change implements byte padding of Elliptic Curve point byte representations to match the required field size.
Checklist