Skip to content

Implement byte padding for Elliptic Curve point encoding as fix for #173#174

Merged
fszlin merged 4 commits intofszlin:masterfrom
webprofusion:master
Dec 13, 2018
Merged

Implement byte padding for Elliptic Curve point encoding as fix for #173#174
fszlin merged 4 commits intofszlin:masterfrom
webprofusion:master

Conversation

@webprofusion-chrisc
Copy link
Collaborator

Description

This change implements byte padding of Elliptic Curve point byte representations to match the required field size.

Checklist

  • [X ] All tests are passing
  • [ X] New tests were created to address changes in pr (and tests are passing)
  • [X ] Updated README and/or documentation, if necessary

@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #174 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   95.21%   95.22%   +<.01%     
==========================================
  Files         103      103              
  Lines        2342     2344       +2     
  Branches      256      256              
==========================================
+ Hits         2230     2232       +2     
  Misses         57       57              
  Partials       55       55

@webprofusion-chrisc
Copy link
Collaborator Author

Ok, I think this is clean enough to leave as-is, unless @fszlin has any suggestions!

@webprofusion-chrisc
Copy link
Collaborator Author

webprofusion-chrisc commented Dec 12, 2018

I have added attributes to JsonWebKey and it's derivatives to enforce the serialization order of properties. One user was getting an incorrect Account Key thumbprint during challenges as the key properties were serializing in a different (non-alphabetical) order resulting in a different json string being hashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants