New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement byte padding for Elliptic Curve point encoding as fix for #173 #174

Open
wants to merge 3 commits into
base: master
from

Conversation

1 participant
@webprofusion-chrisc
Collaborator

webprofusion-chrisc commented Nov 24, 2018

Description

This change implements byte padding of Elliptic Curve point byte representations to match the required field size.

Checklist

  • [X ] All tests are passing
  • [ X] New tests were created to address changes in pr (and tests are passing)
  • [X ] Updated README and/or documentation, if necessary
@codecov

This comment has been minimized.

codecov bot commented Nov 24, 2018

Codecov Report

Merging #174 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   95.21%   95.22%   +<.01%     
==========================================
  Files         103      103              
  Lines        2342     2344       +2     
  Branches      256      256              
==========================================
+ Hits         2230     2232       +2     
  Misses         57       57              
  Partials       55       55
@webprofusion-chrisc

This comment has been minimized.

Collaborator

webprofusion-chrisc commented Nov 26, 2018

Ok, I think this is clean enough to leave as-is, unless @fszlin has any suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment