feat (Frame): Accept all supported options to goto#49
Merged
Conversation
This expands the list of selected options for `PlaywrightEx.Frame.goto/2` to match those of the JavaScript API ([docs](https://playwright.dev/docs/api/class-page#page-goto)). I found that in CI, I was often hitting 30 second timeouts waiting for the `load` event—even though in the trace, I could clearly see the page had (at least conceptually!) loaded. When switching to `waitUntil: 'commit'` (rather than the default `waitUntil: 'load'`), not only did the flakiness of that initial page load get fixed, but the tests also got _much_ faster: from an average of >5 seconds per test down to under 1.5 seconds/test.
This was referenced May 12, 2026
Owner
|
Beautiful, thanks!
Is there any downside to using |
ftes
approved these changes
May 13, 2026
ftes
pushed a commit
to ftes/phoenix_test_playwright
that referenced
this pull request
May 13, 2026
The corresponding change to be able to use [#49 from playwright_ex](ftes/playwright_ex#49). The description from that PR: > This expands the list of selected options for `PlaywrightEx.Frame.goto/2` to match those of the JavaScript API ([docs](https://playwright.dev/docs/api/class-page#page-goto)). > > I found that in CI, I was often hitting 30 second timeouts waiting for the `load` event—even though in the trace, I could clearly see the page had (at least conceptually!) loaded. When switching to `waitUntil: 'commit'` (rather than the default `waitUntil: 'load'`), not only did the flakiness of that initial page load get fixed, but the tests also got _much_ faster: from an average of >5 seconds per test down to under 1.5 seconds/test. > > (The `Referer` stuff isn't strictly necessary for my own work, but I figured while I was in here, I might as well make `goto` accept everything the JavaScript version does.) It doesn't feel _great_ having the docs copied and pasted between the two projects, but it seemed cleaner than, say, exposing a function from PlaywrightEx that would provide the options at compile-time.
Contributor
Author
|
Thank you! Re: whether |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the list of selected options for
PlaywrightEx.Frame.goto/2to match those of the JavaScript API (docs).I found that in CI, I was often hitting 30 second timeouts waiting for the
loadevent—even though in the trace, I could clearly see the page had (at least conceptually!) loaded. When switching towaitUntil: 'commit'(rather than the defaultwaitUntil: 'load'), not only did the flakiness of that initial page load get fixed, but the tests also got much faster: from an average of >5 seconds per test down to under 1.5 seconds/test.(The
Refererstuff isn't strictly necessary for my own work, but I figured while I was in here, I might as well makegotoaccept everything the JavaScript version does.)