Add filename parameter to configureLogger function#2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
happy_python_logging.app.configureLogger()にfilenameパラメータを追加しました。filenameパラメータが指定された場合、ロガーのハンドラはそのファイルに出力しますfilenameパラメータが指定されていない場合、ロガーのハンドラは(これまで通り)標準エラー出力に出力します実装詳細
LoggerConfigurationTypedDictにfilenameパラメータを追加configureLogger関数を更新してfilenameパラメータを処理するように変更すべてのテストが正常に通過することを確認済みです。
これにより、Issue #1 が解決されます。