docs: improve VNC access, env vars, and screenshot coordinate docs#82
Merged
docs: improve VNC access, env vars, and screenshot coordinate docs#82
Conversation
Address 6 documentation feedback items: - Add "Web VNC Access" section with port architecture table and step-by-step flow - Fix VNC_WEB_PORT description to clarify it controls redirect URLs, not container listen port - Document nested API response structure (.data.token) with inline comments - Add DEVICE_SCALE_FACTOR impact on screenshot dimensions and coordinate mapping - Add guidance on DISPLAY_WIDTH/HEIGHT vs VIEWPORT_WIDTH/HEIGHT relationship - Confirm /api/eval uses "script" param (already consistent across all docs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Add .claude/skills/quickstart/SKILL.md: step-by-step guide that checks if fuba-browser is running, helps start it, issues a VNC URL (with hostname prompt for remote access), and shows API/CLI cheat sheet - Add CLAUDE.md: project-level context for Claude Code with key conventions (response structure, VNC token flow, param names) - Add .claude/settings.local.json to .gitignore (user-specific) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move skill source from .claude/skills/quickstart/ to skills/fuba-recorder-setup/ - Symlink .claude/skills/fuba-recorder-setup → ../../skills/fuba-recorder-setup so Claude Code discovers it while the source lives in a distributable location - Rename from /quickstart to /fuba-recorder-setup (project-specific name) - Improve skill content: add argument-hint, refine VNC hostname prompt flow - Add "Claude Code Integration" section to README with install instructions - Update CLAUDE.md to reference new skill name Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add Step 2 that verifies the host meets minimum requirements before starting fuba-browser: - Memory: 4GB minimum, 8GB+ recommended (STOP if insufficient) - CPU: 2 cores minimum, 4+ recommended (WARN if low) - Docker: must be installed (STOP if missing) - Shared memory: 2GB (handled by launcher/compose) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ユーザーからのドキュメント改善要望6件に対応:
VNC_WEB_PORTの説明を「リダイレクトURLで使用するポート」に修正.data.tokenのネスト）を明記/api/evalパラメータ名 (chore(ci): bump aquasecurity/trivy-action from 0.28.0 to 0.33.1 #4): コード・CLI・ドキュメント全てでscriptに統一済みであることを確認（変更不要）Test plan
🤖 Generated with Claude Code