Skip to content

fix: add the try-with-resource when use URLClassLoader #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

fix: add the try-with-resource when use URLClassLoader #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions src/main/java/org/fugerit/java/junit5/tag/check/ExecutedTestTagReporterMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,27 +61,29 @@ public void execute() throws MojoExecutionException {

try {
// Build classpath for test classes
URLClassLoader classLoader = createTestClassLoader();
try (URLClassLoader classLoader = createTestClassLoader()) {

// Parse Surefire reports to find executed tests
List<ExecutedTest> executedTests = TagSurefireFacade.parseSurefireReports( this.surefireReportsDirectory, this.includeSkipped );
// Parse Surefire reports to find executed tests
List<ExecutedTest> executedTests = TagSurefireFacade.parseSurefireReports( this.surefireReportsDirectory, this.includeSkipped );

getLog().info("Found " + executedTests.size() + " executed tests");
getLog().info("Found " + executedTests.size() + " executed tests");

// Extract tags from executed tests
Map<ExecutedTest, Set<String>> testTagMap =
TagScanFacade.extractTagsFromExecutedTests(executedTests, classLoader);
// Extract tags from executed tests
Map<ExecutedTest, Set<String>> testTagMap =
TagScanFacade.extractTagsFromExecutedTests(executedTests, classLoader);

// Generate report
TagReportFacade.generateReport( this.format, this.includeSkipped, this.outputFile, testTagMap);
// Generate report
TagReportFacade.generateReport( this.format, this.includeSkipped, this.outputFile, testTagMap);

// Check for required tags
if (requiredTags != null && !requiredTags.isEmpty()) {
TagCheckFacade.checkRequiredTags( this.requiredTags, this.failOnMissingTag, testTagMap);
}
// Check for required tags
if (requiredTags != null && !requiredTags.isEmpty()) {
TagCheckFacade.checkRequiredTags( this.requiredTags, this.failOnMissingTag, testTagMap);
}

getLog().info("Executed Test Tag Report generated: " +
outputFile.getAbsolutePath());

getLog().info("Executed Test Tag Report generated: " +
outputFile.getAbsolutePath());
}

} catch (Exception e) {
throw new MojoExecutionException("Error generating executed test tag report", e);
Expand Down