Conversation
Explanation:
If we have a route like this '/hello/world/' splitting by slashes:
```
["", "hello", "world", ""]
```
By default, leading slash is trimmed out, so actually we have:
```
["hello", "world", ""]
```
Now the trailing item (empty string) should be a child of the resource
itself (that allow you to handle resources ending in slash). That is
working now.
The second part is the base case. Since leading slash is being trimmed
out, these two cases should be equivalent:
```
r.Resource("") == r.Resource("/")
```
Now it is not! `r.Resource("")` is the `r` itself whereas `r.Resource("/")`
is a child node with the empty string path.
With this fix behavior is consistent in all cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation:
If we have a route like this '/hello/world/' splitting by slashes:
By default, leading slash is trimmed out, so actually we have:
Now the trailing item (empty string) should be a child of the resource
itself (that allow you to handle resources ending in slash). That is
working now.
The second part is the base case. Since leading slash is being trimmed
out, these two cases should be equivalent:
Now it is not!
r.Resource("")is theritself whereasr.Resource("/")is a child node with the empty string path.
With this fix behavior is consistent in all cases.