Merged
Conversation
|
Coverage after merging release/1.6.1 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares the v1.6.1 release by updating the package version and adding release documentation entries (changelog + blog post + blog index entry).
Changes:
- Bump
package.jsonversion to1.6.1 - Add a
v1.6.1changelog row and docs/blog entries (new release post + index row)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Version bump to 1.6.1 for the release |
| CHANGELOG.md | Adds a v1.6.1 row linking to the blog post |
| docs/blog/release-v1-6-1.md | Adds the v1.6.1 release blog post |
| docs/blog/index.md | Adds v1.6.1 to the blog index table |
| { | ||
| "name": "github-code-search", | ||
| "version": "1.6.0", | ||
| "version": "1.6.1", |
There was a problem hiding this comment.
The PR description says it includes a TUI rendering fix in src/render/ (and related tests), but the actual diff only changes release metadata/docs (package.json + changelog/blog). If the rendering fix is intended for v1.6.1, please include the corresponding code/test changes in this PR (or adjust the description/version bump accordingly) before cutting the release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
When a file contained multiple matches, the TUI rendering loop only displayed the first
TextMatchfragment and dropped the rest, due to an incorrect indexing assumption.What changed
src/render/— fix fragment iteration to render all text matches for a given filepackage.json— bumped to1.6.1CHANGELOG.md— added v1.6.1 entrydocs/blog/release-v1-6-1.md— patch blog postdocs/blog/index.md— added v1.6.1 rowSteps to reproduce (before the fix)
Search for a query that produces multiple matches in the same file. In the TUI, only the first extract was visible for that file.
Steps to verify (after the fix)
Same search: all extracts for the file are now visible in the TUI, consistent with the markdown/JSON output.
References
Fixes #75