hotfix: serve /stats SPA shell on showcase server (was 404 in prod)#51
Merged
Merged
Conversation
Quick task 260514-1nv shipped the /stats Angular page with RenderMode.Client but missed updating server.js's exact-match whitelist (which serves the SPA shell for /dashboard). On v0.9.69 deploy to main, /stats returned 404 from fly.io until this fix. Mirrors the /dashboard pattern verbatim. /stats/* (trailing path) still falls through to 404 — same Easter-egg posture (footer link to bare /stats is the only entry).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick task 260514-1nv shipped the `/stats` Angular page with `RenderMode.Client` but missed updating `showcase/server/server.js`'s exact-match whitelist (which serves the SPA shell for `/dashboard`). v0.9.69 deploy went green, but `https://full-selfbrowsing.com/stats\` returned 404 on first hit.
Two-line fix in `showcase/server/server.js` — adds `/stats` to:
`/stats/*` (trailing path) still falls through to 404 — same Easter-egg posture (footer link to bare `/stats` is the only entry).
Test plan