ci: add TypeScript type-check step to CI workflows #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. **test-core.yml**: Added a "Type check" step that runs `npm run build` before tests 2. **test-mikroorm-driver.yml**: Added a "Type check MikroORM driver" step that runs `npm run build` on the mikroorm-driver workspace before tests This ensures TypeScript type errors are caught early in CI before tests run, preventing the issue where tests could pass while type errors exist in the code.
jtomaszewski
force-pushed
the
vk/fccf-add-typescript-t
branch
from
c7d7c60 to
55c56b3
Compare
jtomaszewski
added a commit
that referenced
this pull request
Dec 3, 2025
jtomaszewski
added a commit
that referenced
this pull request
Dec 3, 2025
…ntPoller (#4) * test workflows run twice in a PR? (vibe-kanban 7dc44370) see #8 * feat(core): add graceful shutdown handling to RetryableInboxOutboxEventPoller Implement OnModuleDestroy lifecycle hook to properly clean up resources during application shutdown: - Unsubscribe from RxJS interval to stop polling - Track in-flight event processing and wait for completion - Add isShuttingDown flag to prevent new processing during shutdown 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The recent CI failure was caused by TypeScript type errors in test files that weren't caught earlier because the workflow only ran tests, not type-checking. Tests were using string literals instead of the proper enum values, which passed locally but failed during the build step.
Solution
Added dedicated TypeScript type-check steps (
npm run build) that run before tests to catch type errors early in the CI pipeline.🤖 Generated with Claude Code