fix: update phantom ref test from failing to passing

[TaduJR]

Summary

Updates the it.failing test added in #149 to it, since the phantom ref injection bug is now fixed by fullstorydev/fullstory-babel-plugin-react-native#64.

The non-enumerable synthetic ref fix in the babel plugin prevents sharedRefWrapper from leaking through {...rest} spreads in custom components, so the test now passes as expected.

Dependency

This PR should land after fullstorydev/fullstory-babel-plugin-react-native#64 is merged and a new version of @fullstory/babel-plugin-react-native is published.

[RyanCommits]

@TaduJR Looks like there are lint errors https://app.circleci.com/pipelines/gh/fullstorydev/fullstory-react-native/468/workflows/625aef3c-8ade-410c-80f3-b766680ae718/jobs/526

Also, there will be two additional failing tests will your change from fullstorydev/fullstory-babel-plugin-react-native#64:
Reading FS properties on iOS › Reads fs properties correctly
and Reading FS properties on iOS › Annotate plugin annotates correctly

[TaduJR]

@RyanCommits,

The CI failure is expected this PR depends on fullstorydev/fullstory-babel-plugin-react-native#64 being merged and published first.

CI runs npm ci which installs the current published @fullstory/babel-plugin-react-native (unfixed), so the phantom ref test fails because the bug is still present. Once fullstorydev/fullstory-babel-plugin-react-native#64 is merged and a new version is published, CI will install the fixed plugin and all tests will pass.

I've verified locally:

• With the fix from fix: make synthetic refs non-enumerable to prevent leaking through rest spreads fullstory-babel-plugin-react-native#64 copied into node_modules: 15/15 tests pass
• Without the fix (published version): the phantom ref test fails as expected

Also fixed the lint formatting issue from the previous push.

[RyanCommits]

• With the fix from fix: make synthetic refs non-enumerable to prevent leaking through rest spreads fullstory-babel-plugin-react-native#64 copied into node_modules: 15/15 tests pass

Unfortunately this is not something that I am seeing locally when running npx jest --config jest.config.js --clearCache && npm run test:src. I am seeing two tests fail.

What we can do to verify in CI is change the npm install path to your branch:
"@fullstory/babel-plugin-react-native": "github:TaduJR/fullstory-babel-plugin-react-native#fix/react-19-non-enumerable-synthetic-refs".

You'll also need to change these lines to include src/index.js

[TaduJR]

Hi @RyanCommits,

As discussed, I've updated the dependency to install from my fix branch:

"@fullstory/babel-plugin-react-native": "github:TaduJR/fullstory-babel-plugin-react-native#fix/react-19-non-enumerable-synthetic-refs"

I also committed lib/index.js to the babel plugin branch so it's available when installed from GitHub (since devDependencies aren't installed for GitHub deps, the prepare script can't build).

The package.json dependency should be reverted back to a version range (e.g. "^1.7.0") before merging, once fullstorydev/fullstory-babel-plugin-react-native#64 is merged and published.

[TaduJR]

Hi @RyanCommits,

Thanks for merging fullstorydev/fullstory-babel-plugin-react-native#64

Bumped @fullstory/babel-plugin-react-native to ^1.6.3 to pick up the fix from fullstorydev/fullstory-babel-plugin-react-native#64. CI has passed now.

[TaduJR]

Hey @RyanCommits

How is it going on this one?

[TaduJR]

Seems @RyanCommits might be OoO

Anyone would like to review?

cc @JoshMiers-FS @martin-fs @ScottLNorvell

TIA 🙏.

[RyanCommits]

LGTM, update to 1.6.4