Skip to content

fix combobox reopen on click#432

Merged
franklinlindemberg merged 1 commit into
masterfrom
fix/combobox-reopen-on-click
Jul 1, 2026
Merged

fix combobox reopen on click#432
franklinlindemberg merged 1 commit into
masterfrom
fix/combobox-reopen-on-click

Conversation

@franklinlindemberg

@franklinlindemberg franklinlindemberg commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

when we select an item in the combobox, if we click it again it is not opening (unless we click somewhere else on the screen first). This PR fixes that.


Note

Low Risk
Single-line event binding change in combobox UI behavior with no backend or security impact.

Overview
Fixes gRPC service/method comboboxes so the suggestion list opens again when you click the field right after picking a value, without having to blur away first.

The combobox text input only ran autocomplete("search", …) on focus. After a selection the input often stays focused, so another click did not refire that handler. The same handler is now bound to focus and click, so a click always reopens the dropdown with the current value.

Reviewed by Cursor Bugbot for commit a7770de. Bugbot is set up for automated code reviews on this repo. Configure here.

@dragonsinth dragonsinth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@franklinlindemberg franklinlindemberg merged commit 48d2193 into master Jul 1, 2026
3 checks passed
@franklinlindemberg franklinlindemberg deleted the fix/combobox-reopen-on-click branch July 1, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants