use go 1.13 to build docker image #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonsinth
reviewed
May 15, 2020
| @@ -1,10 +1,6 @@ | |||
| FROM golang:1.11.10-alpine as builder | |||
| FROM golang:1.13.10-alpine3.11 as builder | |||
Member
There was a problem hiding this comment.
hmm, i wouldn't have expected the trailing version number on alpine
Contributor
Author
There was a problem hiding this comment.
It isn't strictly necessary. It's to pin the version. You can also specify just golang:1.13-alpine, to leave point release from Go and version entirely from alpine, and it will just pick up latest of each.
I thought including full versions would be good for repeatability -- always using the same version of Go and alpine to build the docker image.
dragonsinth
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With go 1.11, building with modules in a vanilla docker image required installing more junk.
With go1.13, mui simple.