Skip to content

update lead version to Go 1.25#543

Merged
dragonsinth merged 1 commit intomasterfrom
125
Jan 22, 2026
Merged

update lead version to Go 1.25#543
dragonsinth merged 1 commit intomasterfrom
125

Conversation

@dragonsinth
Copy link
Member

@dragonsinth dragonsinth commented Jan 22, 2026

Part of #528

Copilot AI review requested due to automatic review settings January 22, 2026 19:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to update the lead Go version from 1.23 to 1.25 across Docker and CI configurations. The changes include modernizing Dockerfile syntax (MAINTAINER to LABEL, lowercase to uppercase AS) and updating the CircleCI build matrix to remove Go 1.22 and add Go 1.25 testing.

Changes:

  • Updates Dockerfile to use Go 1.25 and modernizes Dockerfile syntax
  • Adds Go 1.25 build job to CircleCI configuration
  • Removes Go 1.22 build job from CircleCI workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Dockerfile Updates base image from golang:1.23-alpine to 1.25-alpine; modernizes MAINTAINER to LABEL syntax and capitalizes AS keyword in multi-stage builds
.circleci/config.yml Removes build-1-22 job, adds build-1-25 job to test matrix, and updates workflow to include Go 1.25 testing
Comments suppressed due to low confidence (1)

.circleci/config.yml:33

  • The build-1-25 job uses different steps than build-1-23 and build-1-24. While build-1-23 and build-1-24 use the shared simple_job_steps anchor that runs 'make test', build-1-25 explicitly defines its steps to run 'make ci'. This inconsistency means that Go 1.25 (which would be the lead version) runs different commands than the other versions. Consider using the same simple_job_steps anchor for consistency, or if 'make ci' should be the standard, update all jobs to use it.
    steps:
      - checkout
      - run:
          name: Run tests and linters
          command: |
            make ci

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dragonsinth dragonsinth merged commit 6caf0e7 into master Jan 22, 2026
9 checks passed
@dragonsinth dragonsinth deleted the 125 branch January 22, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants