-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(skills): rename setup-plugin to verify-setup, drop install branch #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chiplay
wants to merge
1
commit into
main
Choose a base branch
from
refocus-setup-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --- | ||
| name: verify-setup | ||
| description: Verify the Subtext plugin/extension is connected and diagnose MCP connectivity or auth failures. Does not install — see https://subtext.fullstory.com/install/ for first-time setup. | ||
| metadata: | ||
| requires: | ||
| skills: ["subtext:shared"] | ||
| --- | ||
|
|
||
| # Verify Setup | ||
|
|
||
| Confirm Subtext is wired up correctly and diagnose failures. This skill assumes the plugin/extension is already installed — you wouldn't be reading it otherwise. For first-time install, point users at https://subtext.fullstory.com/install/. | ||
|
|
||
| ## When to use | ||
|
|
||
| - User asks *"is Subtext working?"* or *"is it set up?"* | ||
| - A Subtext MCP tool just failed and you need to diagnose why | ||
| - Invoked implicitly by `subtext:onboard` when an early MCP call errors out | ||
|
|
||
| ## Step 1: Test MCP connectivity | ||
|
|
||
| Try a lightweight MCP call to confirm the server is reachable. Listing tools on the `subtext` server is a good probe — it doesn't require any session or scope beyond auth. | ||
|
|
||
| Servers to consider: | ||
| - `subtext` (US) or `subtext-eu1` (EU) — required for review, live, comments. Whichever the user's account region uses. | ||
| - `subtext-tunnel` — optional, only needed for hosted-browser flows against a localhost dev server. | ||
|
|
||
| If the call succeeds, the plugin is connected. Report which servers are reachable and move to Step 2. | ||
|
|
||
| If the call fails, classify the failure: | ||
|
|
||
| - **Tool / server not registered** (the MCP server name isn't even available) → the plugin or extension isn't activated in this agent. Tell the user to enable it via their platform's extension/plugin UI. Don't prescribe specific UI flows — different platforms differ; ask the user to check whichever they're on. | ||
| - **401 / 403 / "auth required"** → MCP server is reachable but unauthenticated. Tell the user to complete the OAuth flow (typically opens a browser on first tool use), or to configure an API key per their platform's MCP server settings. Detailed install/auth steps live at https://subtext.fullstory.com/install/. | ||
| - **Network error / 5xx / timeout** → MCP server is unreachable. Suggest checking network and retrying. If persistent, escalate to subtext@fullstory.com. | ||
|
|
||
| ## Step 2: Verify local dependencies | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to move this into the sightmap skill in a separate PR? |
||
|
|
||
| The sightmap upload script (`skills/shared/collect_and_upload_sightmap.py`) needs Python 3 + PyYAML. Run as a single command: | ||
|
|
||
| ```bash | ||
| python3 --version 2>&1 && python3 -c "import yaml; print('PyYAML OK')" 2>&1 | ||
| ``` | ||
|
|
||
| - No Python 3 → suggest the user's OS-appropriate install (e.g. `brew install python@3.12` on macOS). | ||
| - No PyYAML → suggest `python3 -m pip install pyyaml`. | ||
|
|
||
| These aren't fatal — Subtext's MCP tools work without sightmap upload — but agents that try to upload sightmap on session start will fail silently if these are missing. | ||
|
|
||
| ## Step 3: Report | ||
|
|
||
| If everything passes: | ||
|
|
||
| > "Subtext is connected. MCP servers reachable, deps OK." | ||
|
|
||
| If something failed, report the specific failure and the next step you suggested. Stay terse — the user wants to get unstuck, not read a plumbing essay. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how the last part would actually get triggered since they already have the plugin at this point. Maybe Im missing a flow that you're envisioning here 🤔. Also how will the agent know if its their first time installing?