fix(e2e): match simplified landing page in navigation tests#37
Merged
Conversation
The landing page was simplified in 171ffa7 to surface only an 'Experiments' link, but the navigation suite still expected a direct 'Prime Moments' link on /. Update the two failing tests to walk the current path: / -> /x -> /x/prime-moments.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The two failing navigation tests still expected a direct `Prime Moments` link on `/`, but commit 171ffa7 simplified the landing page to surface only an `Experiments` link. The third test (`experiments index lists prime moments`) was already passing and stays unchanged.
The new walk matches the simplified site model: `/` → click `Experiments` → `/x` → click `Prime Moments` → `/x/prime-moments`.
Verified locally: `bunx playwright test e2e/navigation.spec.ts` — 3 passed.
Note: the noisy `BLOB_READ_WRITE_TOKEN is not set` log lines in CI come from `proxy.spec.ts` hitting blob-writing code without a token. Those tests pass (writes are fire-and-forget, page returns 200 via error boundary), but the noise is real. Follow-up PR will introduce an in-process fake blob server for E2E so the blob paths get exercised properly.