Conversation
priagungs
requested review from
jonathan016,
oliverrsebastian and
rickykennedy25
|
|
||
| @Configuration | ||
| public class SwaggerConfiguration { | ||
| public class SwaggerConfiguration extends WebMvcConfigurerAdapter { |
There was a problem hiding this comment.
Just forget to remove it, i added swagger ui config in my local. Swagger ui doesn't work in release branch, and i forget to raise issue about it. Will be removed and issue will be raised soon
There was a problem hiding this comment.
Yes, in release branch swagger was not working, but it is fixed in PR for CORE-39, so after that PR is merged, swagger should be working
| @WithAnyRole(roles = { | ||
| Role.STUDENT, Role.MENTOR, Role.JUDGE, Role.ADMIN | ||
| }) | ||
| @WithAnyRole |
There was a problem hiding this comment.
This will allow guest to access, is this the expected behavior?
| import org.springframework.http.HttpStatus; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Comparator; |
There was a problem hiding this comment.
Is this used? If not please remove
| .map(user -> chatroomRepository.findAllByTitleContainingIgnoreCaseAndMembersOrderByCreatedAtDesc( | ||
| .map(user -> chatroomRepository.findAllByTitleContainingIgnoreCaseAndMembersOrderByUpdatedAtDesc( | ||
| keyword, user, pageable)) | ||
| .orElse(PageHelper.empty(pageable)); |
There was a problem hiding this comment.
Use orElseGet so that empty page is not created on method execution
…ontroller role access, remove unused import
| Session session | ||
| @RequestParam(required = false, defaultValue = "10") int size | ||
| ) { | ||
| if (chatroomId.equalsIgnoreCase("public")) { |
There was a problem hiding this comment.
remember to refactor this to be moved in service layer later
3 participants
bug fix on chatroom sorting