Fix RoleBinding ownership conflict for multi-function namespaces#107
Merged
creydr merged 1 commit intofunctions-dev:mainfrom Apr 29, 2026
Merged
Conversation
The shared deploy-function RoleBinding previously set a single Function as the controller owner, overwriting any prior owner. Deleting that Function would garbage-collect the RoleBinding, breaking other Functions in the same namespace. Use controllerutil.SetOwnerReference to append each Function as a non-controller owner so the RoleBinding is only cleaned up when all Functions in the namespace are deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-function-defaultRoleBinding previously set a single Function as the controller owner (Controller: true), overwriting any prior owner reference. Deleting that Function would garbage-collect the RoleBinding, breaking deployments for other Functions in the same namespace.controllerutil.SetOwnerReferenceto append each Function as a non-controller owner, so the RoleBinding is only cleaned up when all Functions in the namespace are deleted.deployFunctionRoleBindingNameconstant.