feat: pass registry auth secret as --image-pull-secret to func CLI#126
Open
creydr wants to merge 2 commits intofunctions-dev:mainfrom
Open
feat: pass registry auth secret as --image-pull-secret to func CLI#126creydr wants to merge 2 commits intofunctions-dev:mainfrom
--image-pull-secret to func CLI#126creydr wants to merge 2 commits intofunctions-dev:mainfrom
Conversation
creydr
changed the title
--image-pull-secret to func CLI
When spec.registry.authSecretRef is set, pass the secret name via --image-pull-secret so the func CLI sets imagePullSecrets directly on the function's pod spec.
creydr
force-pushed
the
image-pull-secret-cli-flag
branch
from
2f250eb to
de2f8fb
Compare
Verify that when spec.registry.authSecretRef is set, the operator passes --image-pull-secret to func deploy and the Knative Service's pod template receives imagePullSecrets. Also exclude dupl linter for test/ directory.
creydr
force-pushed
the
image-pull-secret-cli-flag
branch
from
de2f8fb to
224a525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.registry.authSecretRefis set, the operator now passes the secret name via--image-pull-secrettofunc deploy, so the func CLI setsimagePullSecretsdirectly on the function's pod specImagePullSecretfield toDeployOptionsand wires it through the CLI argument constructionDeploy()is called with the correctImagePullSecretwhenauthSecretRefis configuredToDo:
--image-pull-secretparam (https://github.com/knative/func/pull/3656/changes)