Merged
Conversation
The release workflow was failing because the Makefile uses yq to add version and commit labels to the installation manifest, but yq was not installed in the GitHub Actions environment. This change adds a yq target to the Makefile that automatically downloads yq v3.4.1 from GitHub releases to the local bin/ directory, following the same pattern used for other tools like kustomize and operator-sdk. The build-installer target now depends on yq and uses $(YQ) instead of the bare yq command to ensure the correct version is used.
creydr
changed the title
yq version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow was failing because the Makefile uses yq to add version and commit labels to the installation manifest, but yq 4 was installed in the GitHub Actions environment (while we used yq 3 style in our Makefile).
This change adds a yq target to the Makefile that automatically downloads yq v3.4.1 from GitHub releases to the local bin/ directory, following the same pattern used for other tools like kustomize and operator-sdk.
The build-installer target now depends on yq and uses $(YQ) instead of the bare yq command to ensure the correct version is used.