Add errorprone plugin with NullAway to build #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates ErrorProne static analysis with NullAway null safety checking into the Java build pipeline. The main purpose is to enhance code quality by catching null pointer issues at compile time.
Key changes include:
- Configure ErrorProne plugin with NullAway checker in the build system
- Migrate from
@NullMarkedannotations on individual classes to package-level null safety - Add explicit null checks using
Objects.requireNonNull()where needed - Remove Lombok dependency in favor of manual implementations
Reviewed Changes
Copilot reviewed 41 out of 42 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tasks-jvm/build.gradle.kts | Adds ErrorProne plugin configuration with NullAway checker |
| tasks-jvm/src/main/java/org/funfix/tasks/jvm/package-info.java | Introduces package-level @NullMarked annotation |
| Multiple test files | Removes class-level @NullMarked annotations and adds explicit null checks |
| Multiple source files | Removes @NullMarked annotations and replaces Lombok with manual implementations |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexandru
added a commit
that referenced
this pull request
Feb 1, 2026
* Update README * Add Resource (#12) * v0.1.0 * @nullable Executor * v0.1.1 * Add errorprone plugin with NullAway to build (#13) * v0.1.2 * Fix concurrency bug * Trampoline#forkAll optimisation * v0.1.3 * Remove Resource.Closeable * v0.2.0 * Update Javadoc link * Fix config * v0.2.1 * Add more @Blocking annotations, improve tests * Task#withOnComplete, Task#withCancellation (#14) * v0.3.0 * Trigger build on tags * Add Fiber#joinBlockingUninterruptible * v0.3.1 * Initial plan * Merge origin/main and restore build configuration - Merged origin/main with Kotlin build configuration preserved - Removed Scala module and updated settings.gradle.kts - Updated build configuration to include errorprone plugin - Added errorprone dependencies to buildSrc and libs.versions.toml - Integrated latest tasks-jvm code from origin/main Co-authored-by: alexandru <11753+alexandru@users.noreply.github.com> * Fix cancellation handling in fromCancellableFuture - Added CancellationException to the list of exceptions that trigger onCancellation - Fixed order of cancellation: cancel CompletableFuture before calling custom cancellable to avoid race condition where future completes before being cancelled - All tests now pass including gradle check Co-authored-by: alexandru <11753+alexandru@users.noreply.github.com> --------- Co-authored-by: Alexandru Nedelcu <noreply@alexn.org> Co-authored-by: Alexandru Nedelcu <alexandru@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexandru <11753+alexandru@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.