Skip to content

Conversation

@cmalinmayor
Copy link
Contributor

@cmalinmayor cmalinmayor commented Mar 28, 2025

Proposed Change

Because we don't re-download the zip if it is already present, if it gets corrupted it will stay corrupted forever. There was clearly something reproducible that was corrupting it in our workflow that is still undiscovered (Killing the process during unzip, maybe?). But, now we catch the exception and re-download the zip, removing the corrupt version.

Closes #31

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.

@cmalinmayor cmalinmayor merged commit 1eb9a6f into v0.2-dev Mar 28, 2025
4 checks passed
@cmalinmayor cmalinmayor deleted the bugfix-zip branch April 2, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants