Skip to content

Conversation

@AnniekStok
Copy link
Collaborator

@AnniekStok AnniekStok commented Jul 17, 2025

Proposed Change

Allow export to geff in addition to export to CSV. To test this new feature, click on the 'export' button of an item in the TracksList, and select 'geff'. A QFileDialog should open to allow you to choose a file ending with '.zarr'. If a folder with this name exists already, QFileDialog will ask whether to overwrite. When a valid filepath is chosen, a directory will be created here and the data will be saved as geff.

Further Comments

Requires closing issue #56

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (bff6554) to head (5126556).

Files with missing lines Patch % Lines
.../track_data_views/views_coordinator/tracks_list.py 5.88% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   89.47%   89.44%   -0.03%     
==========================================
  Files         650      650              
  Lines       60149    60169      +20     
==========================================
+ Hits        53816    53821       +5     
- Misses       6333     6348      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AnniekStok AnniekStok requested a review from cmalinmayor July 17, 2025 20:22
Copy link
Contributor

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a beautiful PR and I love it 🤩 once we merge the funtracks pr and release 1.1.0, we can update our pyproject.toml to say funtracks>=1.1.0, make sure the tests pass, and then merge

@AnniekStok AnniekStok merged commit 6140cb9 into main Jul 21, 2025
5 of 10 checks passed
@AnniekStok AnniekStok deleted the 88-update-export-button-to-save-to-geff branch July 21, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants