Skip to content

graph.nodes|edges setter doesn't need list#207

Draft
TeunHuijben wants to merge 1 commit intomainfrom
fix-single-node-api-needs-list
Draft

graph.nodes|edges setter doesn't need list#207
TeunHuijben wants to merge 1 commit intomainfrom
fix-single-node-api-needs-list

Conversation

@TeunHuijben
Copy link
Copy Markdown
Collaborator

wait for trackdata PR royerlab/tracksdata#284 to be merged+released, then we should update the pyproject here

Closes #196

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.35%. Comparing base (6d9c5a8) to head (bdb9c95).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files          59       59           
  Lines        3249     3249           
=======================================
  Hits         3033     3033           
  Misses        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅

@cmalinmayor cmalinmayor marked this pull request as ready for review April 29, 2026 11:39
@cmalinmayor cmalinmayor marked this pull request as draft April 29, 2026 11:39
Copy link
Copy Markdown
Contributor

@cmalinmayor cmalinmayor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay now I understand, this is blocked until we can depend on a new release of tracksdata 🙃 then it's an easy merge, but until then no rush, since the old way works

@cmalinmayor cmalinmayor added the blocked PR blocked by something else label Apr 29, 2026
@TeunHuijben
Copy link
Copy Markdown
Collaborator Author

Update: the blocking tracksdata PR has been merged. Now waiting for some other td merges, so we can combine them in a new td release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PR blocked by something else

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tracksdata] does graph.nodes[][] really need a list?

2 participants