Skip to content

Minimal changes to get desired tracklet id functionality#226

Draft
cmalinmayor wants to merge 5 commits into
mainfrom
fix-tracklet-attr-forwarding
Draft

Minimal changes to get desired tracklet id functionality#226
cmalinmayor wants to merge 5 commits into
mainfrom
fix-tracklet-attr-forwarding

Conversation

@cmalinmayor
Copy link
Copy Markdown
Contributor

Potential, less drastic alternative to #213

Includes changing the default arg in tracks, and a larger change to the segmentation export where we don't allow passing in any feature key anymore - just specify if you want the segmentation relabeled by lienage id or track id or not.

Includes changing the default arg in tracks, and a larger change to the segmentation export where we don't allow passing in any feature key anymore - just specify if you want the segmentation relabeled by lienage id or track id or not.
# Conflicts:
#	tests/import_export/test_import_from_geff.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.38%. Comparing base (d4a4596) to head (a2d269b).

Files with missing lines Patch % Lines
...rc/funtracks/import_export/_export_segmentation.py 93.33% 1 Missing ⚠️
src/funtracks/import_export/_validation.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   93.29%   93.38%   +0.08%     
==========================================
  Files          59       59              
  Lines        3222     3233      +11     
==========================================
+ Hits         3006     3019      +13     
+ Misses        216      214       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmalinmayor cmalinmayor requested a review from TeunHuijben May 28, 2026 19:40
@TeunHuijben
Copy link
Copy Markdown
Collaborator

@cmalinmayor, thanks! I changed some docstrings in my last commit:

Question:

Comments:

  • import csv (src/funtracks/import_export/csv/_import.py#L154-L161): track_id not recorded in geff metadata when a older csv is loaded with track_id instead of tracklet_id
  • Do we accept that when loading an older geff that has "track_id", that we ignore that entry, and recompute the new "tracklet_id"? I think we should; we will otherwise forever have to deal with backward compatibility and detect both names. Just to flag this.
  • create_empty_graphview_graph still has a special case for track_id, keep this, or rename to tracklet_id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants