209 update to geff v1 compatibility#90
Conversation
… no attribute track_id_to_node
…e id and track id if provided, and if invalid, remove them from selected_attrs when creating the networkx graph
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 89.00% 89.32% +0.32%
==========================================
Files 25 25
Lines 1128 1134 +6
==========================================
+ Hits 1004 1013 +9
+ Misses 124 121 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # Create metadata and add the affine matrix. Axes will be added automatically. | ||
| metadata = GeffMetadata( | ||
| geff_version=geff.__version__, |
There was a problem hiding this comment.
@msschwartz21 an example of our API being inconvenient - Anniek had to make a GeffMetadata to store related objects, but most of the other metadata stuff gets populated by our write thing, so this code is a little silly (plus i'm not sure if we gets the right geff-spec version overwritten)
Anniek - this should technically be geff-spec.version
cmalinmayor
left a comment
cmalinmayor
left a comment
There was a problem hiding this comment.
Use the nice geff API :) instead of the secret confusing one
…c version in metadata
cmalinmayor
left a comment
cmalinmayor
left a comment
There was a problem hiding this comment.
Amazing - thanks!! 🦷 🪥
2 participants
No description provided.