Use annotators to compute features at graph construction and after actions#97
Merged
cmalinmayor merged 20 commits into2-feature-infrastructurefrom Oct 27, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 2-feature-infrastructure #97 +/- ##
============================================================
+ Coverage 90.59% 90.70% +0.10%
============================================================
Files 39 39
Lines 1659 1656 -3
============================================================
- Hits 1503 1502 -1
+ Misses 156 154 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
| ] | ||
|
|
||
| @classmethod | ||
| def get_managed_features(cls, tracks: Tracks) -> dict[str, Feature]: |
Contributor
Author
There was a problem hiding this comment.
Still don't like that this returns the default string keys. Can we really just do the Features?
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 24, 2025
cmalinmayor
commented
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of features included: