Test fixes for PR 87 (pt. 2) #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These made sense when `gzip` was treated as an alias of `zlib`. However as that was incorrect and this PR fixes that issue, there is no alias and it does not make sense to test for one. Hence these tests are dropped.
Drop the extra blank line at the end of the file.
8 tasks
Owner
|
Thanks a lot! |
Author
|
Sure. Sadly missed a few flake8 errors that CI caught. Sorry about that. PR should fix them ( #3 ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a couple other test fixes for PR ( zarr-developers#87 ) as discussed in that PR. Namely drops the alias tests and commits a gzip test fixture.
Edit: Pushed a fix for the flake8 error as well.