Fix SVG D1 inserts and add commenting guidelines#2
Merged
Conversation
…-Org#818) D1's stmt.bind() rejects undefined values with "D1_TYPE_ERROR: Type 'undefined' not supported". The admin media upload route declared width/height as `number | undefined` and left thumbnail_url as undefined for non-image files, which broke SVG uploads since the dimension extractor is intentionally skipped for SVGs and never populated the values. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Added guidelines for self-explanatory code commenting, including principles, examples, and anti-patterns to avoid.
Added guidelines for structuring code and projects to enhance GitHub Copilot's effectiveness through better context management.
furelid
merged commit 681297d
into
copilot/fix-plugin-auto-mounting-issue-758
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
Changes
Testing
Unit Tests
E2E Tests
Screenshots/Videos
Checklist
Generated with Claude Code in Conductor