Conversation
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good. Worth considering though. View full project report here.
| class OSRelease(models.Model): | ||
|
|
||
| name = models.CharField(max_length=255, unique=True, blank=False, null=False) | ||
| name = models.CharField(max_length=128, unique=True, blank=False, null=False) |
There was a problem hiding this comment.
| name = models.CharField(max_length=128, unique=True, blank=False, null=False) | |
| name = models.CharField(max_length=128, unique=True) |
False is the default value Django uses for blank, so blank=False can be removed. Explained here.
Again, redundant default arguments can be removed.
| codename = models.CharField(max_length=255, blank=True) | ||
| cpe_name = models.CharField(max_length=255, null=True, blank=True, unique=True) | ||
| codename = models.CharField(max_length=128, blank=True) | ||
| cpe_name = models.CharField(max_length=128, null=True, blank=True, unique=True) |
There was a problem hiding this comment.
null=True on a string field causes inconsistent data types because the value can be either str or None. This adds complexity and maybe bugs, but can be solved by replacing null=True with default="". More.
| epoch = models.CharField(max_length=255, blank=True, null=True) | ||
| version = models.CharField(max_length=255) | ||
| release = models.CharField(max_length=255, blank=True, null=True) | ||
| epoch = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| epoch = models.CharField(max_length=128, blank=True, null=True) | |
| epoch = models.CharField(max_length=128, blank=True, default='') |
null=True on a string field causes inconsistent data types because the value can be either str or None. This adds complexity and maybe bugs, but can be solved by replacing null=True with default="". More details.
| release = models.CharField(max_length=255, blank=True, null=True) | ||
| epoch = models.CharField(max_length=128, blank=True, null=True) | ||
| version = models.CharField(max_length=128) | ||
| release = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| release = models.CharField(max_length=128, blank=True, null=True) | |
| release = models.CharField(max_length=128, blank=True, default='') |
As above, consider replacing null=True with default="" (and blank=True to pass validation checks).
| arch = models.CharField(max_length=255) | ||
| name = models.CharField(max_length=128) | ||
| version = models.CharField(max_length=128) | ||
| epoch = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| epoch = models.CharField(max_length=128, blank=True, null=True) | |
| epoch = models.CharField(max_length=128, blank=True, default='') |
As above, consider replacing null=True with default="" (and blank=True to pass validation checks).
| name = models.CharField(max_length=128) | ||
| version = models.CharField(max_length=128) | ||
| epoch = models.CharField(max_length=128, blank=True, null=True) | ||
| release = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| release = models.CharField(max_length=128, blank=True, null=True) | |
| release = models.CharField(max_length=128, blank=True, default='') |
Again, consider replacing null=True with default="" (and blank=True to pass validation checks).
| arch = models.CharField(max_length=128) | ||
| packagetype = models.CharField(max_length=1, blank=True, null=True) | ||
| category = models.CharField(max_length=255, blank=True, null=True) | ||
| category = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| category = models.CharField(max_length=128, blank=True, null=True) | |
| category = models.CharField(max_length=128, blank=True, default='') |
Again, consider replacing null=True with default="" (and blank=True to pass validation checks).
|
|
||
| score = models.DecimalField(max_digits=3, decimal_places=1, null=True) | ||
| severity = models.CharField(max_length=255, blank=True, null=True) | ||
| severity = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| severity = models.CharField(max_length=128, blank=True, null=True) | |
| severity = models.CharField(max_length=128, blank=True, default='') |
null=True on a string field causes inconsistent data types because the value can be either str or None. This adds complexity and maybe bugs, but can be solved by replacing null=True with default="". More details.
| severity = models.CharField(max_length=128, blank=True, null=True) | ||
| version = models.DecimalField(max_digits=2, decimal_places=1) | ||
| vector_string = models.CharField(max_length=255, blank=True, null=True) | ||
| vector_string = models.CharField(max_length=128, blank=True, null=True) |
There was a problem hiding this comment.
| vector_string = models.CharField(max_length=128, blank=True, null=True) | |
| vector_string = models.CharField(max_length=128, blank=True, default='') |
Same as above: consider replacing null=True with default="" (and blank=True to pass validation checks).
1 participant
closes: #722