Fix/name collision on import#17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Summary
Hardens entity-creation endpoints against client-supplied id collisions:
POST /services,/stacks,/github-repositories,/prerequisitesnow reject duplicateid/namewith409 Conflictand a descriptive message instead of silently overwriting state or surfacing a generic store error.POST /stacks/importgains anassertNoImportConflictspre-flight that collects every collidingstack.name,service.id,repository.id, andprerequisite.idand returns a single409. This prevents the existing rollback path from being entered for avoidable collisions (which would have deleted the pre-existing colliding records)./services,/stacks,/prerequisites) roll back the records they have already inserted when a later step fails, so a failed create no longer leaves orphan rows.🧪 Tests
409+ check-result rollback specs forPOST /prerequisites.stack.nameand cross-stack duplicateservice.idspecs forPOST /stacks/import.