Conversation
For consistency. The change is backwards compatible on both case-sensitive and insensitive file systems.
One parenthesis was misplaced on this line.
I think things look better with slightly slower animation.
Change to NPM style package@version in ToString().
Member
Author
|
This one should be good to go now... |
kusma
reviewed
Jul 15, 2019
| Options = options; | ||
| BundleDirectory = Path.Combine(project.CacheDirectory, "bundle"); | ||
| CacheDirectory = Path.Combine(project.CacheDirectory, "builds", (options.BuildTarget + options.Configuration).GetHashCode().ToString("X8")); | ||
| CacheDirectory = Path.Combine(project.CacheDirectory, "builds", (options.BuildTarget + options.Configuration).GetHashCode().ToString("x8")); |
Contributor
There was a problem hiding this comment.
I know the commit message says this is backwards compatible, but how come it is?
Member
Author
There was a problem hiding this comment.
The cache files are regenerated automatically when not found, so renaming the directory has no other consequences than improving naming consistency.
Contributor
There was a problem hiding this comment.
Right. So you'll end up with two cache-directories until the cache gets cleared?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some subtle tweaks, mostly to some logging code.