Theme customizer#82
Merged
skrolikowski merged 5 commits intofusioncms:nightlyfrom Jul 1, 2020
kaidesu:theme-customizer
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement or fix?
Refactored the way the theme customizer displays previews. Instead of sending theme option values within the URL query string, it now makes a
POSTrequest to thecustomizeendpoint, which then forwards the request to the desired page. It then takes the content of the request and replaces the contents of the iFrame, effectively updating the preview without any reloads 👍theme_previewto determine if the current request is in preview mode due to customizingDoes this close any currently open issues?
Screenshots