Automatically merge theme manifest changes in#85
Merged
skrolikowski merged 3 commits intofusioncms:nightlyfrom Jul 7, 2020
kaidesu:theme-options
Merged
Automatically merge theme manifest changes in#85skrolikowski merged 3 commits intofusioncms:nightlyfrom kaidesu:theme-options
skrolikowski merged 3 commits intofusioncms:nightlyfrom
kaidesu:theme-options
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement or fix?
Moved the responsibility of creating the theme option cache file out from the
theme_optionhelper function to the service provider. This not only cleans up the responsibilities, but allows us to catch when a theme manifest has been updated, prompting that we should check for changes and merge options as necessary.No longer need to visit the frontend before jumping to the customize page ✌️
Does this close any currently open issues?
resolves Theme option changes don't reflect immediately fusioncms#576
All javascript/scss resources are compiled for production