Skip to content
This repository was archived by the owner on Aug 1, 2018. It is now read-only.

Fix prepare algorithm with new Provider/Context api#109

Merged
old-fusion-bot[bot] merged 2 commits intofusionjs:masterfrom
ganemone:master
Jul 5, 2018
Merged

Fix prepare algorithm with new Provider/Context api#109
old-fusion-bot[bot] merged 2 commits intofusionjs:masterfrom
ganemone:master

Conversation

@ganemone
Copy link
Copy Markdown
Contributor

@ganemone ganemone commented Jul 5, 2018

This fixes a bug where the prepare algorithm stopped traversing once it hit a component generated from the new react context API. This would break server side data fetching for any users using the React.createContext API.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 5, 2018

Codecov Report

Merging #109 into master will decrease coverage by 0.53%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   78.62%   78.08%   -0.54%     
==========================================
  Files           9        9              
  Lines         145      146       +1     
  Branches       36       34       -2     
==========================================
  Hits          114      114              
- Misses         20       21       +1     
  Partials       11       11
Impacted Files Coverage Δ
src/prepare.js 90.9% <100%> (+0.21%) ⬆️
src/dispatched.js 12.5% <0%> (-12.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3594177...9f83b11. Read the comment docs.

@ganemone
Copy link
Copy Markdown
Contributor Author

ganemone commented Jul 5, 2018

!merge

@old-fusion-bot old-fusion-bot bot merged commit 5475193 into fusionjs:master Jul 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants