This repository was archived by the owner on Aug 1, 2018. It is now read-only.
Support React.createContext()#90
Merged
old-fusion-bot[bot] merged 1 commit intofusionjs:masterfrom Apr 10, 2018
Merged
Conversation
resolves fusionjs#88 Use the [`react-is`](https://github.com/facebook/react/blob/76b4ba01290f446f4313adf3846954412c6051b8/packages/react-is/src/ReactIs.js#L71) package to detect `<Fragment />` + `<Context.Provider />` + `<Context.Consumer />`. bump the `devDependencies` on `react` + `react-dom` to `16.3.0` since that is when `React.createContext()` was released.
koulmomo
force-pushed
the
feature/support-context
branch
from
463ffcf to
7bbb988
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 75.91% 76.59% +0.68%
==========================================
Files 8 8
Lines 137 141 +4
Branches 32 36 +4
==========================================
+ Hits 104 108 +4
Misses 22 22
Partials 11 11
Continue to review full report at Codecov.
|
lhorie
approved these changes
Apr 10, 2018
KevinGrandon
approved these changes
Apr 10, 2018
KevinGrandon
approved these changes
Apr 10, 2018
Contributor
KevinGrandon
left a comment
KevinGrandon
left a comment
There was a problem hiding this comment.
Nice work with the tests!
Contributor
|
!merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #88
Use the
react-ispackage to detect<Fragment />+<Context.Provider />+<Context.Consumer />.bump the
devDependenciesonreact+react-domto16.3.0since that is whenReact.createContext()was released.