Basic Nimbus support#103
Merged
fustom merged 7 commits intofustom:mainfrom Sep 13, 2023
domenicoblanco:main
Merged
Conversation
Owner
|
Wow! Thank you! I will review your request soon. |
Contributor
Author
|
Thanks! |
Owner
|
I merged Nimus device into Galevo device. Please test the new code and let me know if everything works as expected. |
Contributor
Author
|
As |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I used this library for a while and finally decided to inspect the Ariston APIs to find how the cooling consumptions are calculated. Unluckily the energyAccount endpoint returns an empty list, so I tried to obtain it differently.
The difference between Galevo and Nimbus is made with a value that I hope is false for Galevo devices (
HPMP_SYS) as I read that are condensing boilers.In any case, feel free to reject this PR as I understand could cause problems to other users