Fix cool index#107
Merged
fustom merged 2 commits intofustom:mainfrom Sep 13, 2023
Merged
Conversation
Owner
|
Thanks. That was my mistake. Your fix was perfect, but I like my way better. Do you use my HASS integration? https://github.com/fustom/ariston-remotethermo-home-assistant-v3 |
Contributor
Author
|
Yeah, I thought the same but didn't change in a single dict anyway because maybe there was a reason that I didn't know. Of course! I'm testing locally and soon will make a new PR in the other repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry to open a new PR so soon but, while trying to implement this new attribute with HASS, I noticed that
electandcoolweren't keys in the same dict but different dicts in a list