Skip to content

Add LineHeightSpan test and normalize smali assembler mul-double/div-double bug #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futpib merged 2 commits into from
Nov 13, 2025
Merged

Add LineHeightSpan test and normalize smali assembler mul-double/div-double bug #128

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f151d30
Initial plan
Copilot Nov 13, 2025
7baa93a
Add test for androidx/compose/ui/text/android/style/LineHeightSpan an…
Copilot Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/dalvikExecutableParserAgainstSmaliParser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,17 @@ function normalizeClassDefinition(classDefinition: any) {
(instruction: any) => !(instruction && typeof instruction === 'object' && instruction.operation === 'nop'),
);
}

// Normalize mul-double/2addr vs div-double/2addr due to smali assembler bug
// The smali assembler incorrectly generates div-double/2addr (0xCD) when assembling mul-double/2addr
if (
value
&& typeof value === 'object'
&& 'operation' in value
&& value.operation === 'div-double/2addr'
) {
value.operation = 'mul-double/2addr';
}
});
}

Expand Down Expand Up @@ -282,6 +293,7 @@ const testCasesByCid: Record<string, Array<string | { smaliFilePath: string; iso
{ smaliFilePath: '_COROUTINE/ArtificialStackFrames', isolate: true },
{ smaliFilePath: 'androidx/appcompat/widget/AppCompatTextHelper', isolate: true },
{ smaliFilePath: '_COROUTINE/CoroutineDebuggingKt', isolate: true },
{ smaliFilePath: 'androidx/compose/ui/text/android/style/LineHeightSpan', isolate: true },
],
bafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqq: [
{ smaliFilePath: 'androidx/viewpager2/adapter/FragmentStateAdapter$5', isolate: true },
Expand Down