Add b4/v test case and fix smaliParser boolean handling #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test coverage for the
b4/vclass from DEX filebafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqq.Changes
b4/vwith isolation to the test cases array for the specified CIDtruevalues instaticValues. The parser was incorrectly treatingtrueas a default value when it's actually non-default (onlyfalseis the default for boolean fields in DEX format).Technical Details
The
b4/vclass has two static boolean fields initialized totruein DEX. The smali parser was not populating these into thestaticValuesarray because it incorrectly consideredtrueto be a default value.Changes in
smaliParser.ts:lastIndexWithInitializerlogic to includeinitValue === truechecktruefor fields withinitialValue: truefalsetrueis non-default whilefalseandnullare defaultsThis ensures the smali parser output matches the DEX parser output for static boolean fields with non-default values.
bafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqq+b4/vparseDexAgainstSmaliMacro test like others and make it pass #171Original prompt
bafybeiebe27ylo53trgitu6fqfbmba43c4ivxj3nt4kumsilkucpbdxtqq+b4/vparseDexAgainstSmaliMacro test like others and make it pass #171💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.