Complete reverseRegistersOperations set for 12x format Dalvik bytecode operations #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reverseRegistersOperationsset was incomplete, causing register order mismatches between DEX bytecode and Smali text parsing for operations likeor-int/2addr.Root cause: Dalvik 12x format stores registers as
B|A(nibbles), but Smali syntax isop vA, vB. The nibbles parser returns[B, A], requiring reversal to match Smali's[A, B]order.Changes:
/2addroperations:or-int/2addr,xor-int/2addr,shl-int/2addr,shr-int/2addr,ushr-int/2addr,rem-int/2addr,and-int/2addr, and long/double variantsneg-*,not-*int-to-*,long-to-*,float-to-*,double-to-*rsub-longOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.