Feature/openapispec #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
reviewed
Nov 10, 2023
| - 箇条書き2 | ||
| - 箇条書き3 | ||
| ``` | ||
| [ファイルフォーマット規約](yaml_standards.md)に準じる。 |
ota-meshi
reviewed
Nov 10, 2023
| - 文字列として認識させる必要のある数字（"0123"） | ||
| - 60 進数と認識させたくない場合（"12:34"） | ||
| - Bool として認識させたくない（"true", "false", "yes", "no", "y", "n", "on", "off"） |
Member
There was a problem hiding this comment.
「YAML 1.2を用いる」とあるにもかかわらず、YAML 1.2ではboolとして認識しない「"yes", "no", "y", "n", "on", "off"」が例として書いてあるのは違和感があります。また、60進数も同様です。
パーサーが1.1として解釈してしまうことを考慮しているなら注記があった方が良いと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.