Skip to content

Remove: opt_select_limit, opt_sort_clause #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanzaku merged 2 commits into from
Mar 31, 2025
Merged

Remove: opt_select_limit, opt_sort_clause #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aafb3bf
change(tree-sitter module): remove opt_select_limit
lemonadern Mar 31, 2025
822b9b8
change(tree-sitter module): remove opt_sort_clause
lemonadern Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion crates/postgresql-cst-parser/src/tree_sitter/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,9 @@ fn walk_and_build(
| SyntaxKind::select_no_parens
| SyntaxKind::simple_select
| SyntaxKind::select_clause
| SyntaxKind::opt_target_list => {
| SyntaxKind::opt_select_limit
| SyntaxKind::opt_target_list
| SyntaxKind::opt_sort_clause => {
// [Node: Removal]
//
// Ignore current node, and continue building its children.
Expand Down Expand Up @@ -279,6 +281,26 @@ FROM
let (new_root, _) = get_ts_tree_and_range_map(input, &root);
assert_not_exists(&new_root, SyntaxKind::opt_target_list);
}

#[test]
fn no_opt_select_limit() {
let input = "select a from t for update limit 5 offset 5;";
let root = cst::parse(input).unwrap();
assert_exists(&root, SyntaxKind::opt_select_limit);

let (new_root, _) = get_ts_tree_and_range_map(input, &root);
assert_not_exists(&new_root, SyntaxKind::opt_select_limit);
}

#[test]
fn no_opt_sort_clause() {
let input = "select a from t order by a desc limit 5;";
let root = cst::parse(input).unwrap();
assert_exists(&root, SyntaxKind::opt_sort_clause);

let (new_root, _) = get_ts_tree_and_range_map(input, &root);
assert_not_exists(&new_root, SyntaxKind::opt_sort_clause);
}
}

mod flatten {
Expand Down