Skip to content

fix: Remove reversing of the sections in compose version#84

Merged
SumeraMartin merged 1 commit intomasterfrom
bugfix/fix-section-ordering-for-compose-version
Apr 16, 2022
Merged

fix: Remove reversing of the sections in compose version#84
SumeraMartin merged 1 commit intomasterfrom
bugfix/fix-section-ordering-for-compose-version

Conversation

@SumeraMartin
Copy link
Copy Markdown
Member

@matejsemancik this is fix for the following issue #83 since colors are separated from the data and data are reversed, there is a bug that was causing the colors were not assigned to the correct values. It is clearly a bug, but it is going to reverse colors for everybody who is going to update the library. Do you think that we should proceed with this change and add a comment to the changelog or fix the issue somehow differently?

@futured-bot
Copy link
Copy Markdown

4 Warnings
⚠️ Branch name should have release/, hotfix/, fix/, housekeep/ or feature/ prefix.
⚠️ Please start subject with capital letter.
c90fba1
⚠️ library/src/main/kotlin/app/futured/donut/DonutProgressView.kt#L22 - Class DonutProgressView is too large. Consider splitting it into smaller pieces.
⚠️ sample/src/main/kotlin/app/futured/donutsample/ui/playground/compose/PlaygroundComposeActivity.kt#L3 - Imports must be ordered in lexicographic order without any empty lines in-between

Generated by 🚫 Danger

@matejsemancik
Copy link
Copy Markdown
Member

This is clearly a bug that went unnoticed. My take would be to fix it and mention the change in the changelog.

Copy link
Copy Markdown
Member

@matejsemancik matejsemancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and it behaves correctly now 👌

@SumeraMartin SumeraMartin merged commit cceddc4 into master Apr 16, 2022
@SumeraMartin SumeraMartin deleted the bugfix/fix-section-ordering-for-compose-version branch April 16, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants