Skip to content

Team updates#1

Merged
chrisfrank merged 7 commits intofutureproject:masterfrom
maggit:team-updates
Feb 9, 2016
Merged

Team updates#1
chrisfrank merged 7 commits intofutureproject:masterfrom
maggit:team-updates

Conversation

@maggit
Copy link

@maggit maggit commented Feb 4, 2016

  • In the “About” folder, move the “team” post from _drafts to _posts to make it show up on the About page
  • The links in "" should replace existing content via AJAX, instead of loading a new page/anchor.
  • While the hover state of each of the above links should
    stay the same, the active background color should be #00cfff
  • The font used for people’s names (.person .person-name) should be:
- font-weight: 800
- font-size: 1.2em
- letter-spacing: 0px
  • Remove “Team” from the top-level site navigation menu. (It should just appear a sub-section of “About”.)

@chrisfrank
Copy link
Contributor

This is great, Raquel, thank you. Can you make just a few adjustments before I merge and push it live?

  1. The .team-nav links should actually link to separate HTML pages, not to anchors of the same page. Similarly, the content for each team should be spread across the different pages, so that the About page won't be a 10 Mb page load just to show one team.
  2. When a user with JS disabled clicks one of those .team-nav links, they should be taken to the page for the team they clicked. For a user with JS enabled, clicking those links should preventDefault, load in the new content via AJAX, and replace the team that's currently displayed.
  3. The div that contains each team should not have a ".post" class, since it's already in a .post div. Getting rid of the .post class should remove the double-gradient and extra padding highlighted in the attached screenshot.
  4. The color of active-state team buttons is correct, but their hover-state (and the sass constant $hover-blue) should remain #0064f4.

screen shot 2016-02-04 at 4 27 15 pm

@chrisfrank chrisfrank merged commit 08a0b7a into futureproject:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants