Skip to content

Adopt fonts from the product, and add links to other landing pages#121

Merged
dschwarz26 merged 1 commit intomainfrom
docs-style
Feb 10, 2026
Merged

Adopt fonts from the product, and add links to other landing pages#121
dschwarz26 merged 1 commit intomainfrom
docs-style

Conversation

@dschwarz26
Copy link
Contributor

Screenshot 2026-02-09 at 2 24 57 PM

Comment on lines +328 to +332
.landing-title-brand {
font-family: var(--font-jetbrains), "JetBrains Mono", ui-monospace, monospace;
color: var(--brand-primary);
font-weight: 600;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The .landing-title-brand class requests font-weight: 600, but the JetBrains_Mono font is only loaded with weights 300, 400, and 500, causing a font fallback.
Severity: MEDIUM

Suggested Fix

To resolve the font mismatch, either add "600" to the weight array in the JetBrains_Mono font configuration in layout.tsx, or change the font-weight property in the .landing-title-brand CSS class from 600 to an available weight like 500.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs-site/src/app/globals.css#L328-L332

Potential issue: The CSS class `.landing-title-brand` in `globals.css` specifies
`font-weight: 600`. However, the `JetBrains_Mono` font configuration in `layout.tsx`
only loads weights `300`, `400`, and `500`. This mismatch prevents the browser from
rendering the text with the intended font weight. As a result, the browser will
substitute a system fallback font for the "everyrow" text on the landing page, leading
to a visual inconsistency that undermines the intended design.

Did we get this right? 👍 / 👎 to inform future reviews.

Comment on lines +15 to +20
const jetbrainsMono = JetBrains_Mono({
subsets: ["latin"],
display: "swap",
weight: ["300", "400", "500"],
variable: "--font-jetbrains",
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The JetBrains Mono font is used with font-weight: 600 by the .landing-title-brand class, but this weight is not loaded in layout.tsx, causing a font rendering issue.
Severity: MEDIUM

Suggested Fix

In docs-site/src/app/layout.tsx, add "600" to the weight array for the JetBrains_Mono font definition to make this weight available for use.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs-site/src/app/layout.tsx#L15-L20

Potential issue: The `layout.tsx` file configures the `JetBrains_Mono` font to be loaded
only with weights `["300", "400", "500"]`. However, the CSS class
`.landing-title-brand`, which is used on the main documentation landing page, specifies
`font-weight: 600` for this font. Because the 600 weight is not loaded, the browser will
either try to synthesize a bold version from an existing weight or fall back to a
different system font, causing an incorrect visual representation of the title.

Did we get this right? 👍 / 👎 to inform future reviews.

@dschwarz26 dschwarz26 merged commit ff28947 into main Feb 10, 2026
2 checks passed
@dschwarz26 dschwarz26 deleted the docs-style branch February 10, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant