Skip to content

quick fix for agent default behaviour#136

Merged
petermuehlbacher merged 3 commits intomainfrom
quick_fix_of_agent_default_behaviour
Feb 11, 2026
Merged

quick fix for agent default behaviour#136
petermuehlbacher merged 3 commits intomainfrom
quick_fix_of_agent_default_behaviour

Conversation

@petermuehlbacher
Copy link
Contributor

No description provided.

Comment on lines 165 to 171
task: str,
session: Session | None = None,
input: BaseModel | DataFrame | UUID | Result | None = None,
effort_level: EffortLevel | None = EffortLevel.LOW,
effort_level: EffortLevel | None = DEFAULT_EFFORT_LEVEL,
llm: LLM | None = None,
iteration_budget: int | None = None,
include_research: bool | None = None,

This comment was marked as outdated.

Copy link
Contributor

@RafaelPo RafaelPo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a comment explaining iteration_budget=0?

petermuehlbacher and others added 2 commits February 11, 2026 20:33
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@petermuehlbacher petermuehlbacher merged commit 85cc566 into main Feb 11, 2026
5 checks passed
@petermuehlbacher petermuehlbacher deleted the quick_fix_of_agent_default_behaviour branch February 11, 2026 20:39
Comment on lines 144 to 150
task: str,
session: Session | None = None,
input: BaseModel | UUID | Result | None = None,
effort_level: EffortLevel | None = EffortLevel.LOW,
effort_level: EffortLevel | None = DEFAULT_EFFORT_LEVEL,
llm: LLM | None = None,
iteration_budget: int | None = None,
include_research: bool | None = None,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Changing the default effort_level to MEDIUM is a breaking change. Users providing custom parameters must now explicitly set effort_level=None to avoid an API validation error.
Severity: HIGH

Suggested Fix

To avoid breaking existing clients, either revert the default effort_level or, preferably, modify the logic to automatically set effort_level to None if any custom parameters (llm, iteration_budget, etc.) are provided. Additionally, ensure all documentation, including the agent_map docstring, is updated to reflect the correct default behavior.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/everyrow/ops.py#L144-L150

Potential issue: Changing the default `effort_level` to `EffortLevel.MEDIUM` introduces
a breaking change for users providing custom parameters like `llm` or
`iteration_budget`. The API requires that `effort_level` and custom parameters are
mutually exclusive. Users who previously called the function with custom parameters
without explicitly setting `effort_level` will now have the default
`effort_level=MEDIUM` sent along with their custom parameters. This will cause the API
to return a 422 validation error, breaking existing client implementations. The issue is
made worse by outdated docstrings that still list the old default value.

Copy link
Contributor

@jackwildman jackwildman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants