Conversation
Images in docs/images/ weren't included in the Next.js static export. Copied them to docs-site/public/images/ so they're included in the build output, and updated markdown to use absolute paths with the /docs basePath. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment on lines
+1
to
+3
| version https://git-lfs.github.com/spec/v1 | ||
| oid sha256:b2b4b0dc668c3051ed25e7cec0f956fb0d376a059e0620987ac17468c1271fcc | ||
| size 326137 |
There was a problem hiding this comment.
Bug: Images will be broken in production. The build process doesn't download the Git LFS files, and the markdown references incorrect image paths for the Next.js basePath configuration.
Severity: CRITICAL
Suggested Fix
To resolve the Git LFS issue, add lfs: true to the actions/checkout@v4 step in the .github/workflows/deploy-docs.yaml workflow. To fix the pathing, either move the images from docs-site/public/images/ to a new docs-site/public/docs/images/ directory, or update the markdown image references to be root-relative (e.g., /images/learning_curve_accuracy.png) instead of being prefixed with /docs.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: docs-site/public/images/fda_10pct_scaling.png#L1-L3
Potential issue: The deployment workflow does not correctly handle Git LFS-tracked
images. The `actions/checkout@v4` step lacks configuration to pull LFS objects, causing
it to check out small text pointer files instead of the actual image data. Additionally,
the image paths referenced in the markdown files, such as
`/docs/images/learning_curve_accuracy.png`, are incorrect. Due to the Next.js `basePath:
"/docs"` configuration, the server will attempt to find these images at
`public/docs/images/`, but they are located at `public/images/`. This combination of
issues will result in broken images on the deployed documentation site, as browsers will
receive either a 404 error or a text pointer file instead of a renderable image.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/images/were stored as Git LFS pointers and not included in the Next.js static export outputdocs-site/public/images/so they're bundled in the buildimages/...) to absolute (/docs/images/...) to match the basePathTest plan
/docs/active-learning-llm-oracleshows the learning curve chart/docs/scale-deduplication-20k-rowsshows the scaling chart🤖 Generated with Claude Code