Fix docs images by enabling LFS in checkout#144
Merged
Conversation
PNGs were stored as LFS pointers. The deploy workflow checkout doesn't fetch LFS objects, so images were deployed as pointer text files. Removed *.png from .gitattributes LFS tracking and re-added the image files as regular git objects. They're small enough (326KB + 116KB) to store directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RafaelPo
force-pushed
the
fix/docs-images-lfs
branch
from
469d524 to
27db5a6
Compare
Images only need to live in docs-site/public/images/ where Next.js serves them as static assets. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restores *.png to LFS tracking. Adds lfs: true to the deploy workflow checkout so LFS objects (images, CSVs) are fetched during build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reference images via media.githubusercontent.com URLs so the browser fetches them directly from GitHub's LFS CDN. This avoids needing lfs: true in the deploy workflow checkout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/docs/active-learning-llm-oracleand/docs/scale-deduplication-20k-rowsare not renderingactions/checkout@v4) doesn't fetch LFS objects by default, so PNGs are deployed as pointer text fileslfs: trueto the checkout step so LFS objects are fetched during builddocs/images/— they only need to live indocs-site/public/images/Test plan
🤖 Generated with Claude Code