Fix merge parameter descriptions to prevent CC misuse#156
Merged
petermuehlbacher merged 1 commit intomainfrom Feb 18, 2026
Merged
Fix merge parameter descriptions to prevent CC misuse#156petermuehlbacher merged 1 commit intomainfrom
petermuehlbacher merged 1 commit intomainfrom
Conversation
straeter
approved these changes
Feb 17, 2026
petermuehlbacher
force-pushed
the
fix/merge-parameter-descriptions
branch
from
640ca4a to
b737af6
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
petermuehlbacher
force-pushed
the
fix/merge-parameter-descriptions
branch
from
b737af6 to
ca0b3d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.py): Updatedleft_csv/right_csvdescriptions to explain LEFT JOIN asymmetry,merge_on_left/merge_on_rightto discourage unnecessary use, andrelationship_typeto clarifymany_to_oneis the correct default. Added guidance block toeveryrow_mergedocstring with annotated examples.merge_on_left/merge_on_right(the common case). Addedrelationship_typeanduse_web_searchto parameter lists.mcp-server.md,MERGE.md,everyrow-mcp/README.md,ops.py): Consistent descriptions across all user-facing and developer-facing documentation.Motivation
CC consistently misuses three merge parameters:
merge_on_left/merge_on_right— always filled in, but should usually be omitted (auto-detection is better)relationship_type— always set toone_to_one, butmany_to_one(the default) is correct for most mergesleft_csv/right_csv— chosen at random, but merge is asymmetric (LEFT JOIN: left = table being enriched)Root cause: the descriptions CC sees (via MCP tool schema + SKILL.md) didn't convey the correct defaults or the asymmetry.
Test plan
uv run pytest tests/— 23 passed (SDK)uv run pytestin everyrow-mcp — 26 passed, 5 skipped (integration)MergeInput.model_json_schema()output shows updated descriptions🤖 Generated with Claude Code